Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop rendering landuse=greenfield #663

Merged
merged 1 commit into from
Jun 30, 2014
Merged

stop rendering landuse=greenfield #663

merged 1 commit into from
Jun 30, 2014

Conversation

matkoniecz
Copy link
Contributor

It was misleadingly rendered like construction area, I have no idea for acceptable rendering and I think that rendering this landuse in any way is a dubious idea. Fixes #648.

@matkoniecz
Copy link
Contributor Author

Note: this pull request restarted discussion in #648.

@matthijsmelissen
Copy link
Collaborator

I agree with not rendering greenfield, per 'Note that landuse=greenfield currently requires no real changes on the ground, just scheduling area for construction.'

I think greenfield can also be dropped from the query in project.mml in the landcover layer.

@matkoniecz
Copy link
Contributor Author

With this change greenfield name is still rendered. I though that it a good idea but now I am less sure.

@matkoniecz
Copy link
Contributor Author

@matthijsmelissen
Copy link
Collaborator

I think if the colouring goes, the name should go too. Otherwise it becomes very unclear what it refers to.

it was misleadingly rendered like construction area
@matkoniecz
Copy link
Contributor Author

I updated pull request, also names are now gone. AFAIK it is ready for merging.

przechwytywanie

@matkoniecz
Copy link
Contributor Author

Note: I edited this area, big part of landuse=greenfield is now covered also by landuse=farmland

@dieterdreist
Copy link

2014-06-27 17:27 GMT+02:00 Mateusz Konieczny [email protected]:

Note: I edited this area, most of it is now covered by landuse=farmland

you mean you have replaced landuse=greenfield by landuse=farmland?

@matkoniecz
Copy link
Contributor Author

No, I mapped landuse=farmland (as according to Bing it is currently farmland), landuse=greenfield area is unchanged. See https://www.openstreetmap.org/way/148179487

@gravitystorm gravitystorm merged commit 50d1fb2 into gravitystorm:master Jun 30, 2014
@matkoniecz matkoniecz deleted the greenfield branch July 2, 2014 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

landuse=greenfield should not be rendered like landuse=construction
4 participants